Error missing defaults #2864
Merged
Error missing defaults #2864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…anch and pushed it...) This reverts commit 47cdd3b.
|
Ignore the two latest commits. I accidentally pushed some changes that belonged to a different branch. Sorry about the mess. |
|
Looks like that Test just needs to be updated for the new error. Doesn't look like any other changes to the package needed and this is good to go. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I suggest fixing/closing #2857 by forwarding
getdefault()to Symbolics, which already errors if a variable has no defaults.Checklist
contributor guidelines, in particular the SciML Style Guide and
COLPRAC.