feat: implement new discrete saving functionality #2728
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YingboMa
reviewed
May 23, 2024
src/systems/clock_inference.jl
Outdated
| @@ -186,6 +186,10 @@ function split_system(ci::ClockInference{S}) where {S} | |||
| end | |||
| tss[id] = ts_i | |||
| end | |||
| tss[continuous_id], tss[1] = tss[1], tss[continuous_id] | |||
There was a problem hiding this comment.
We cannot assume continuous_id always exists.
AayushSabharwal
force-pushed
the
as/discrete-save
branch
from
da26283 to
054fe1f
Compare
YingboMa
reviewed
May 24, 2024
src/systems/clock_inference.jl
Outdated
| @@ -186,6 +186,13 @@ function split_system(ci::ClockInference{S}) where {S} | |||
| end | |||
| tss[id] = ts_i | |||
| end | |||
| if continuous_id !== 0 | |||
There was a problem hiding this comment.
Where is continuous_id defined in this function?
AayushSabharwal
force-pushed
the
as/discrete-save
branch
2 times, most recently
from
aa3f0ba to
af37ae8
Compare
AayushSabharwal
force-pushed
the
as/discrete-save
branch
3 times, most recently
from
9044096 to
e3c62d1
Compare
AayushSabharwal
force-pushed
the
as/discrete-save
branch
from
e3c62d1 to
616000c
Compare
AayushSabharwal
force-pushed
the
as/discrete-save
branch
from
616000c to
74922ed
Compare
|
Waiting for SciML/SciMLBase.jl#743 |
AayushSabharwal
force-pushed
the
as/discrete-save
branch
from
ef1e4af to
c3b7726
Compare
AayushSabharwal
force-pushed
the
as/discrete-save
branch
from
c3b7726 to
3a073ec
Compare
ChrisRackauckas
approved these changes
Jul 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires:
is_parameter_timeseriestrait, improve parameter timeseries indexing SymbolicIndexingInterface.jl#75AbstractDiffEqArrayRecursiveArrayTools.jl#372PR is based off of this branch right now, will rebase onRebasedmasteronce the above PR is mergedChecklist
contributor guidelines, in particular the SciML Style Guide and
COLPRAC.
Additional context
Add any other context about the problem here.