rm old discrete system #2413
rm old discrete system #2413
Conversation
|
Rebase |
rm more stuff
| isdifference(expr) = isoperator(expr, Difference) | ||
| isdifferenceeq(eq) = isdifference(eq.lhs) |
There was a problem hiding this comment.
These functions are used in other places. Is there a corresponding implementation for the new discrete system? hasshift?
There was a problem hiding this comment.
isdifference is no longer the correct question to ask, you can have an equation that is not a difference equation, but it still belongs to the discrete time domain.
You now have has_discrete_domain and other similar functions in the same file, but they require clock inference to have been run on the model before they are fully usable.
There was a problem hiding this comment.
Here's an example of how clock inference is manually called and the inferred time domain of equations and variables tested
https://github.com/SciML/ModelingToolkit.jl/blob/master/test/clock.jl#L180C1-L194C32
|
I don't have the permissions to push here, so I opened another PR branched off of this one #2440 |
No description provided.