Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improves @icon and adds related docs #2346

Merged
merged 2 commits into from
Nov 7, 2023
Merged

Improves @icon and adds related docs #2346

merged 2 commits into from
Nov 7, 2023

Conversation

ven-k
Copy link
Member

@ven-k ven-k commented Nov 4, 2023

  • Minimally checks the validity of the in-lined SVG.
  • In-lined SVG string can now be specified directly (without being...end)
  • Updates related tests.
  • Documents @icon.

ven-k added 2 commits November 4, 2023 12:27
@ven-k
refactor: improvements to how @icon is parsed
8965a72 
- allows only one `@icon` per model; throws an error ow.
- Although wrapping inlined `@icon` within `begin...end` is still valid; it is no longer required; aka SVGs with just quotes are allowed.
- Validity of SVG-string is verified too.
@ven-k
docs: add @icon section to "Components and Connectors"
645de82
@ven-k ven-k force-pushed the vkb/icons-refactor branch from ea2d850 to 645de82 Compare November 4, 2023 12:39
@YingboMa YingboMa merged commit 70c3252 into SciML:master Nov 7, 2023
17 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YingboMa YingboMa YingboMa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ven-k @YingboMa