feat: support components with fully-qualified names with @mtkmodel
#2330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
closes #2289 |
|
Can you add a test? |
Refactored the existing test code a bit to test this functionality as well in b1e7a0e. |
thazhemadam
force-pushed
the
at/fix-model-parsing-mtkmodel-from-libs
branch
2 times, most recently
from
dd965f6 to
0a6a4c8
Compare
With the `@named` macro, we could use fully-qualified names for
components. However, trying to do the same with `@mtkmodel`,
```
@mtkmodel Model begin
@components begin
resistor = ModelingToolkitStandardLibrary.Electrical.Resistor(R = 1)
...
end
...
end
```
throws the following error.
```
ERROR: LoadError: MethodError: Cannot `convert` an object of type Expr to an object of type Symbol
Closest candidates are:
convert(::Type{T}, ::T) where T
@ Base Base.jl:84
Symbol(::Any...)
@ Base strings/basic.jl:229
```
Fix this and support fully qualified names by considering the
fully-qualifed name's Expr while parsing components.
Refactor out `Pin` and `Ground` into a mock-module `MyMockModule`, so we can use `MyMockModule` and see if `@mtkmodel` works with components that have fully-qualified names (i.e., `MyMockModule.Ground`).
thazhemadam
force-pushed
the
at/fix-model-parsing-mtkmodel-from-libs
branch
from
0a6a4c8 to
d0b2e33
Compare
ChrisRackauckas
approved these changes
Dec 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the
@namedmacro, we could use fully-qualified names for components (for instance, while importing components from the MTKStdLib). However, trying to do the same with@mtkmodel,throws the following error.
Fix this and support fully qualified names by considering the fully-qualifed name's Expr while parsing components.