Support symbolic arrays in @mtkmodel
#2282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ven-k
force-pushed
the
vkb/symbolic-arrays
branch
3 times, most recently
from
5074956 to
ccc6935
Compare
ven-k
force-pushed
the
vkb/symbolic-arrays
branch
from
ccc6935 to
491314f
Compare
|
The test failure is unrelated to this PR; I checked that even master throws the same error. |
ven-k
force-pushed
the
vkb/symbolic-arrays
branch
2 times, most recently
from
442cba7 to
6520fd0
Compare
|
Model Parsing tests pass for Julia 1.61 Footnotes |
YingboMa
reviewed
Oct 23, 2023
src/systems/model_parsing.jl
Outdated
| var = if indices === nothing | ||
| Symbolics.variable(a, T = SymbolicUtils.FnType{Tuple{Real}, Real})(iv) | ||
| else | ||
| vd[a][:length] = lastindex(indices) |
There was a problem hiding this comment.
This won't work for general arrays. Shouldn't it be size?
There was a problem hiding this comment.
As we use Unitranges here, it uses lastindex; but yeah for general arrays that should be broadcasted.
And I've added tests for general arrays; and renamed :length as :size
- and adds relevant tests
- Otherwise test fails with this[^1] deprecation warning. [^1]:https://github.com/SciML/NonlinearSolve.jl/blob/01b067a7d3b8a67d185c11e0d47676903b83e349/src/utils.jl#L37
ven-k
force-pushed
the
vkb/symbolic-arrays
branch
from
c9b8eb3 to
af0a95e
Compare
|
Bump |
YingboMa
approved these changes
Oct 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@mtkmodel@extendin the docs