add module to RuntimeGeneratedFunctions call #2259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChrisRackauckas
approved these changes
Sep 14, 2023
YingboMa
reviewed
Sep 14, 2023
src/systems/pde/pdesystem.jl
Outdated
| p = ps isa SciMLBase.NullParameters ? [] : map(a -> a.first, ps) | ||
| args = vcat(DestructuredArgs(p), args) | ||
| ex = Func(args, [], eq.rhs) |> toexpr | ||
| eq.lhs => drop_expr(RuntimeGeneratedFunction(@__MODULE__, @__MODULE__, ex)) |
There was a problem hiding this comment.
This should not hardcoded. Also, I think only the first argument is necessary for correct precompilation caching.
There was a problem hiding this comment.
This actually doesn't fix the bug I have, I may need to pass down @MODULE from PDESysLibrary as the cache module, this function needs all 3 arguments though
There was a problem hiding this comment.
You can use the @RuntimeGeneratedFunction macro which only needs two.
|
How do you run your formatter? Also, do you have a forced CRLF setting if you are using Windows? |
|
It appears to run automatically with VSCode, I am on MacOS |
|
Have you tried to run it in a vanilla Julia REPL that you start from a terminal? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Again I think my formatter is broken as it keeps trying to format your stuff, don't know what's going on here