typos and Aqua CI

[ArnoStrouwen]

method ambiguity detection maybe can't cope with these weird types?

julia> DelayDiffEq.SciMLBase.SciMLSolution
Union{SciMLSolution, DESolution} (alias for Union{SciMLBase.AbstractEnsembleSolution, SciMLBase.AbstractNoTimeSolution, SciMLBase.AbstractNoiseProcess, SciMLBase.AbstractTimeseriesSolution})

julia> DelayDiffEq.SciMLBase.DESolution
Union{SciMLSolution, DESolution} (alias for Union{SciMLBase.AbstractEnsembleSolution, SciMLBase.AbstractNoTimeSolution, SciMLBase.AbstractNoiseProcess, SciMLBase.AbstractTimeseriesSolution})

[devmotion]

No, I don't think DESolution etc. should be treated as owned by DelayDiffEq. It's just type piracy:

DelayDiffEq.jl/src/utils.jl

Lines 219 to 233 in 3e9c423

	function Base.sizehint!(sol::DESolution, n)
	sizehint!(sol.u, n)
	sizehint!(sol.t, n)
	sizehint!(sol.k, n)
	nothing
	end
	"""
	sizehint!(sol::DESolution, alg, tspan, tstops, saveat; kwargs...)
	Suggest that solution `sol` reserves capacity for a number of elements that
	depends on the parameter settings of the numerical solver.
	"""
	function Base.sizehint!(sol::DESolution, alg, tspan, tstops, saveat;

[devmotion]

There's an unfortunate problem (https://discourse.julialang.org/t/psa-compat-requirements-in-the-general-registry-are-changing/104958#update-november-9th-2023-2) that means it is generally safer to use

Suggested change

	LinearAlgebra = "1"
	Logging = "1"
	LinearAlgebra = "<0.0.1, 1"
	Logging = "<0.0.1, 1"

[devmotion]

Suggested change

	Printf = "1"
	Printf = "<0.0.1, 1"

[devmotion]

Again, I'd prefer to use Aqua.test_all to not miss out on any tests in the future (again, it seems there's some fine-tuning with keyword arguments necessary anyway).
Since the ambiguity check is problematic currently, I suggest (as e.g. in Distributions and Pumas) using

Suggested change

	Aqua.find_persistent_tasks_deps(DelayDiffEq)
	Aqua.test_ambiguities(DelayDiffEq, recursive = false)
	Aqua.test_deps_compat(DelayDiffEq)
	Aqua.test_piracies(DelayDiffEq,
	treat_as_own = [DelayDiffEq.SciMLBase.DESolution,
	DelayDiffEq.SciMLBase.SciMLSolution])
	Aqua.test_project_extras(DelayDiffEq)
	Aqua.test_stale_deps(DelayDiffEq)
	Aqua.test_unbound_args(DelayDiffEq)
	Aqua.test_undefined_exports(DelayDiffEq)
	# Test ambiguities separately without Base and Core
	# Ref: https://github.com/JuliaTesting/Aqua.jl/issues/77
	Aqua.test_all(DelayDiffEq; ambiguities = false)
	Aqua.test_ambiguities(DelayDiffEq)

[ChrisRackauckas]

Oh I didn't know there was a sizehint! overload here. Yeah no that should move to SciMLBase.