Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use miette for json parsing errors #1318

Merged
merged 9 commits into from
Nov 12, 2024
Merged

Conversation

Schniz
Copy link
Owner

@Schniz Schniz commented Nov 12, 2024

  • use miette for everything, i think i should use miette just for json decode for now
  • only on ls-remote
  • fix test
  • use .json instead of failing all the time
  • fix test

@Schniz Schniz self-assigned this Nov 12, 2024
Copy link

changeset-bot bot commented Nov 12, 2024

🦋 Changeset detected

Latest commit: 9930ef7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
fnm Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Nov 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fnm ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 12, 2024 11:29am

@Schniz Schniz merged commit 65f7a22 into master Nov 12, 2024
11 checks passed
@Schniz Schniz deleted the use-miette-for-json-parsing-errors branch November 12, 2024 11:29
This was referenced Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant