Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return x64-musl for built musl binaries #1271

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

fabricionaweb
Copy link

I think it would be nice if the FNM_ARCH could returns x64-musl when is built on musl.

Copy link

changeset-bot bot commented Oct 7, 2024

⚠️ No Changeset found

Latest commit: 07f99aa

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Oct 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fnm ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 7, 2024 3:51pm

@Schniz
Copy link
Owner

Schniz commented Oct 8, 2024

feels like we need to have a list of prioritized platforms, right? so we return [musl, x64] for musl builds, and arm64, x64 for #1068 for instance. we can know which files exist based on the index, or just by requesting them one by one.

@fabricionaweb
Copy link
Author

feels like we need to have a list of prioritized platforms, right? so we return [musl, x64] for musl builds, and arm64, x64 for #1068 for instance. we can know which files exist based on the index, or just by requesting them one by one.

Yes this seems super good. Although I really dont know rust, I really cant help much

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants