Bug/issue 441 high severity vulnerabilities was found #443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Upgrade version of Node.js 12 to 16 * Update deploy-development.yml
heesung6701
approved these changes
Dec 29, 2022
ChoHadam
merged commit db8df23
into
feat/issue-438-modify-getting-recommended-similar-perfumes
ChoHadam
added a commit
that referenced
this pull request
Jan 3, 2023
* [Feat] Modify codes of getting recommended similar perfumes * [Fix] Call different functions depending on the value of perfumeIdxlist * [Fix] Migrating from Promise chains to Async/Await * Add a constant variable of default opcode value * Add comments * Remove unnecessary console outputs * [Feat] Create DAO test code of Updating/Reading recommended similar perfumes * [Feat] Create Service test code of Updating/Reading recommended similar perfumes * [Feat] Create Controller test code of Updating/Reading recommended similar perfumes * [Feat] Create Integral test code of Updating/Reading recommended similar perfumes * [Fix] Add env variables into workflows * Bug/issue 441 high severity vulnerabilities was found (#443) * [Fix] Update package files * Remove unnecessary whitespaces * [Fix] Replace comments with jsDoc
heesung6701
reviewed
Jan 16, 2023
| @@ -73,7 +73,7 @@ | |||
| "@types/swagger-jsdoc": "^6.0.1", | |||
| "@typescript-eslint/eslint-plugin": "^5.16.0", | |||
| "@typescript-eslint/parser": "^5.16.0", | |||
| "babel-plugin-module-resolver": "^4.1.0", | |||
| "babel-plugin-module-resolver": "^2.2.0", | |||
There was a problem hiding this comment.
@ChoHadam
여기서 다운 그레이드 되면서 npm build가 안되는거였네요..! ㅋㅋ 다운그레이드의 비밀 발견
There was a problem hiding this comment.
그러네요ㅠㅋㅋㅋㅋ npm audit fix 잘 알아보고 돌렸어야했는데..
heesung6701
reviewed
Jan 16, 2023
| @@ -36,7 +36,7 @@ | |||
| "express": "^4.17.3", | |||
| "ioredis": "^5.2.4", | |||
| "js-yaml": "^4.1.0", | |||
| "jsonwebtoken": "^8.5.1", | |||
| "jsonwebtoken": "^9.0.0", | |||
There was a problem hiding this comment.
이때 분명히 9.0.0으로 올렸는데...다시 8.5.1 되어 있네요..
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why:
Closes #441
What's being changed:
Update package files with
npm audit fix --force