[Refact] Transfer reviewDao js to ts #360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@heesung6701 |
4 tasks
한번에 수정하는것보다 이렇게 차근차근 수정하는게 리뷰하기도 좋습니다 :) |
|
LGTM |
heesung6701
reviewed
Aug 30, 2022
heesung6701
reviewed
Aug 30, 2022
| nest: true, | ||
| }); | ||
|
|
||
| if (readReviewResult === null) { |
There was a problem hiding this comment.
undefined 인 경우도 이후 코드를 수행하지 않는게 안전할 거 같습니다! undefined인 경우는 존재하지 않아야 하지만..
There was a problem hiding this comment.
💭 undefined을 return할 수도 있다는 가능성을 염두하고 체킹할거라면, 이 경우 뿐 만 아니라 함수를 호출하고 return 값을 사용하는 모든 부분에서 undefined 체크를 해야한다고 생각합니다.
undefined를 전반적으로 허용하지않도록 처리하는 방법을 구글링해봤지만 아직 찾지 못했습니다..
찾게 된다면 공유하고 수정하겠습니다.
ChoHadam
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
기존 reviewDao.js를 제거하고 revireDao.ts를 작성해 새로 연결했습니다.
구현 후 mocha test passing하는것 확인했고,
local server로 돌렸을때 Review 관련 기능들 잘 동작하는지 Swagger docs로 확인했습니다.