Revise Array, ArrayBuffer, BigInt, DataView builtins #1363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Seonghyun Kim <[email protected]>
* Implement missing features on ArrayBuffer * Fix minor bug on BigInt, DataView and Array Signed-off-by: Seonghyun Kim <[email protected]>
…ength is below zero Signed-off-by: Seonghyun Kim <[email protected]>
Signed-off-by: Seonghyun Kim <[email protected]>
clover2123
reviewed
Jul 25, 2024
third_party/yarr/Vector.h
Outdated
Comment on lines
215
to
218
| public: | ||
| using iterator = T*; | ||
| using const_iterator = const T*; | ||
| Escargot::Vector<T, GCUtil::gc_malloc_allocator<T>> impl; |
There was a problem hiding this comment.
minor) what about defining impl as a private member, not public?
If we want to store WTF::String with Vector or HashSet, we would use another type of allocator Signed-off-by: Seonghyun Kim <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.