Implement groupBy, withResolvers method #1352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Seonghyun Kim <[email protected]>
Signed-off-by: Seonghyun Kim <[email protected]>
ksh8281
changed the title
clover2123
reviewed
Jul 2, 2024
src/runtime/PromiseObject.cpp
Outdated
Comment on lines
85
to
89
| PromiseReaction::Capability PromiseObject::newPromiseCapability(ExecutionState& state, const Value& constructor, const Value& parentPromise) | ||
| { | ||
| if (!constructor.isConstructor()) { | ||
| ErrorObject::throwBuiltinError(state, ErrorCode::TypeError, ErrorObject::Messages::Not_Constructor); | ||
| } |
There was a problem hiding this comment.
What about using the existing PromiseObject::newPromiseCapability(ExecutionState& state, Object* constructor, const Value& parentPromise) function instead?
This function is invoked by only one function, and constructor check can be done on the caller side.
Signed-off-by: Seonghyun Kim <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.