RegExp.prototype.compile should not accept sub-class of RegExp

Signed-off-by: Seonghyun Kim <[email protected]>
Samsung · Jul 16, 2024 · bddd8a8 · bddd8a8
1 parent b3deb87
commit bddd8a8
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/src/builtins/BuiltinRegExp.cpp b/src/builtins/BuiltinRegExp.cpp
@@ -203,6 +203,10 @@ static Value builtinRegExpCompile(ExecutionState& state, Value thisValue, size_t
     Optional<Object*> proto = thisValue.asObject()->getPrototypeObject(state);
     Context* calleeContext = state.resolveCallee()->codeBlock()->context();
 
+    if (!proto || !proto->isRegExpPrototypeObject()) {
+        ErrorObject::throwBuiltinError(state, ErrorCode::TypeError, ErrorObject::Messages::GlobalObject_ThisNotRegExpObject);
+    }
+
     bool match = false;
     while (proto) {
         Value c = proto->getOwnProperty(state, ObjectPropertyName(state.context()->staticStrings().constructor)).value(state, proto.value());

diff --git a/tools/test/test262/excludelist.orig.xml b/tools/test/test262/excludelist.orig.xml
@@ -31,7 +31,6 @@
     <test id="intl402/NumberFormat/prototype/formatToParts/signDisplay-ko-KR"><reason>ICU 67 returns wrong result with -0.0001</reason></test>
     <test id="intl402/NumberFormat/prototype/formatToParts/signDisplay-zh-TW"><reason>ICU 67 returns wrong result with -0.0001</reason></test>
 
-    <test id="annexB/built-ins/RegExp/prototype/compile/this-subclass-instance"><reason>TODO</reason></test>
     <test id="annexB/language/comments/multi-line-html-close"><reason>TODO</reason></test>
     <test id="annexB/language/eval-code/direct/script-decl-lex-collision-in-sloppy-mode"><reason>TODO</reason></test>
     <test id="annexB/language/function-code/block-decl-func-skip-arguments"><reason>TODO</reason></test>