Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

drivers/rtk_drv.c: fix build error for imxrt1020-evk/tc #4930

Merged
merged 1 commit into from
May 20, 2021
Merged

drivers/rtk_drv.c: fix build error for imxrt1020-evk/tc #4930

merged 1 commit into from
May 20, 2021

Conversation

deepaksrma
Copy link
Contributor

  • to fix the build error, include netdev_mgr.h header file to provide the reference of netdev.

Signed-off-by: Deepak Sharma [email protected]

@tizen-build
Copy link

Target : [d18a16bf23c6e593d519a35e15bc2394271d7962] - Code Rule Check OK.

jeongchanKim
jeongchanKim previously approved these changes May 6, 2021
View reviewed changes
Copy link
Contributor

@jeongchanKim jeongchanKim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@deepaksrma deepaksrma closed this May 6, 2021
@deepaksrma deepaksrma reopened this May 6, 2021
@tizen-build
Copy link

Target : [c3b4f3a9fe0a13129dc3d0a5095a72fda58fa739] - Code Rule Check OK.

thapav
thapav reviewed May 6, 2021
View reviewed changes
Copy link
Contributor

@thapav thapav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dineshdas-samsung
Copy link
Contributor

LGTM

sunghan-chang
sunghan-chang reviewed May 6, 2021
View reviewed changes
Copy link
Contributor

@sunghan-chang sunghan-chang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not "fix". It just avoid the build break.
Please resolve real problem.

sunghan-chang
sunghan-chang requested changes May 6, 2021
View reviewed changes
Copy link
Contributor

@sunghan-chang sunghan-chang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please find my previous comment.

@sunghan-chang
Copy link
Contributor

Regardless of content, you need to check the title format.
drivers/rtk_drv.c: means location of modification. But you modified defconfig in build/configs/rtk8721csm/tc.
This is wrong usages of commit title.

@deepaksrma
Copy link
Contributor Author

Regardless of content, you need to check the title format.
drivers/rtk_drv.c: means location of modification. But you modified defconfig in build/configs/rtk8721csm/tc.
This is wrong usages of commit title.

yes. you are right. forgot to check it, when i changed the code.
thanks for noticing it.

@deepaksrma
Copy link
Contributor Author

This is not "fix". It just avoid the build break.
Please resolve real problem.

ok. will check it.

@sunghan-chang
Copy link
Contributor

@deepaksrma @sangam-swami Could you let me know the status of this PR? And this looks similar issue on #4759. Is it possible to modify #4759 as well?

@tizen-build
Copy link

Target : [4f16b9c3f389fb8d325fe34a600bfa463f873eec] - Code Rule Check OK.

@deepaksrma
Copy link
Contributor Author

deepaksrma commented May 17, 2021 •
edited
Loading

@deepaksrma @sangam-swami Could you let me know the status of this PR? And this looks similar issue on #4759. Is it possible to modify #4759 as well?

changes are done.

@deepaksrma
drivers/rtk_drv.c: fix build error for imxrt1020-evk/tc
20dce5f 
- error is:

    wireless/realtek/wifi_util_interface/rtk_drv.c: In function 'rtk_drv_initialize':
    wireless/realtek/wifi_util_interface/rtk_drv.c:419:43: error: invalid application of 'sizeof' to incomplete type 'struct netdev'
      419 |  dev = (struct netdev *)kmm_malloc(sizeof(struct netdev));
          |                                           ^~~~~~
    wireless/realtek/wifi_util_interface/rtk_drv.c:423:5: error: dereferencing pointer to incomplete type 'struct netdev'
      423 |  dev->ifname[0] = 'w';
          |     ^~
    wireless/realtek/wifi_util_interface/rtk_drv.c:427:14: error: 'NM_WIFI' undeclared (first use in this function)
      427 |  dev->type = NM_WIFI;

- to fix this, need to include netdev_mgr.h to provide the reference of netdev, so when CONFIG_NET_NETMGR is enabled then it will take the reference from netdev_mgr.h, otherwise from lwnl.h

Signed-off-by: Deepak Sharma <[email protected]>
@tizen-build
Copy link

Target : [20dce5f] - Code Rule Check OK.

@deepaksrma
Copy link
Contributor Author

@deepaksrma @sangam-swami Could you let me know the status of this PR? And this looks similar issue on #4759. Is it possible to modify #4759 as well?

@sunghan-chang we can fix #4759 in other PR as it is related to QEMU build and changes are different.
so you can merge this as of now.

@sunghan-chang sunghan-chang merged commit d1a7c35 into Samsung:master May 20, 2021
@deepaksrma deepaksrma deleted the fix_build_error branch May 20, 2021 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sangam-swami sangam-swami sangam-swami left review comments

@thapav thapav thapav left review comments

@sunghan-chang sunghan-chang sunghan-chang approved these changes

@jeongchanKim jeongchanKim jeongchanKim left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@deepaksrma @tizen-build @dineshdas-samsung @sunghan-chang @jeongchanKim @thapav @sangam-swami