fix: fixed const scope and naming

SamCaliman · Jul 4, 2024 · 68683e6 · 68683e6
1 parent 5752e72
commit 68683e6
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 6 deletions.
diff --git a/api/src/routes/github.ts b/api/src/routes/github.ts
@@ -2,10 +2,11 @@ import { createRouter, HTTPStatus, Result, successfulAuthentication } from 'aeri
 
 export const githubRouter = createRouter()
 
-async function exchangeCodeForAccessToken(code: string) {
+const GITHUB_TOKEN_URL = 'https://github.com/login/oauth/access_token'
 
-  const githubURL = 'https://github.com/login/oauth/access_token'
+const GITHUB_USER_URL = 'https://api.github.com/user'
 
+async function exchangeCodeForAccessToken(code: string) {
   if(!process.env.GITHUB_CLIENT_ID || !process.env.GITHUB_CLIENT_SECRET){
     throw new Error('INVALID ENV FILES')
   }
@@ -19,7 +20,7 @@ async function exchangeCodeForAccessToken(code: string) {
     client_id: CLIENT_ID,
     client_secret: CLIENT_SECRET,
   }
-  const githubResponse = await fetch(githubURL,{
+  const githubResponse = await fetch(GITHUB_TOKEN_URL,{
     method: 'POST',
     body: new URLSearchParams(body),
     headers: {
@@ -31,7 +32,7 @@ async function exchangeCodeForAccessToken(code: string) {
 }
 
 async function fetchUser(token: string) {
-  const userResponse = await fetch('https://api.github.com/user',{
+  const userResponse = await fetch(GITHUB_USER_URL,{
     method: 'GET',
     headers: {
       Authorization: `Bearer ${token}`,

diff --git a/web/src/pages/githubAuth.vue b/web/src/pages/githubAuth.vue
@@ -1,9 +1,9 @@
 <script setup lang="ts">
 
+const CLIENT_ID = import.meta.env.VITE_GITHUB_CLIENT_ID
+const GITHUB_URL = 'https://github.com/login/oauth/authorize'
 
 async function githubAuth() {
-  const CLIENT_ID = import.meta.env.VITE_GITHUB_CLIENT_ID
-  const GITHUB_URL = 'https://github.com/login/oauth/authorize'
   const params = {
     response_type: 'code',
     scope: 'user',