Add duration of audio and VAD removed duration to BatchedInferencePipeline #1186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MahmoudAshraf97
requested changes
Dec 3, 2024
| @@ -114,6 +114,7 @@ def __init__( | |||
| self, | |||
| model, | |||
| ): | |||
| self.logger = get_logger() | |||
There was a problem hiding this comment.
self.model already has a logger, so I'd rather we use the same logger instead of having duplicate loggers in both the pipeline and the model
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the non-batched version of the WhisperModel, you would get logging output like:
Whereas, when calling the BatchedInferencePipeline's
transcribe()method, that is no longer the case.This PR tries to bring that logging back as I believe it does not add extra overhead to the logging and it is quite useful for developers who wish to know how much audio gets processed in the end.
If this is not the case and it is an issue related to my usage of the model, I apologize in advance!