-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test the packaged tox version as well #622
base: main
Are you sure you want to change the base?
Conversation
tests/test_python.py
Outdated
@pytest.mark.xfail( | ||
OS_VERSION in ("15.6", "15.7"), | ||
reason="https://bugzilla.suse.com/show_bug.cgi?id=1232072", | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The xfail doesn't appear to be valid for SP6
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it is valid for SP6, that's where the bug is. the issue is that it is only valid for the python 3.6 version not the python 3.11 version of tox.
I don't know how to express that in an mark.xfail, so for now I've removed the condition. the underlying bug is in progress of being fixed, so with some luck it is released before the next review of this PR happens.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Feel free to merge once the CI is green
pytest.skip("packaged tox not available") | ||
|
||
auto_container_per_test.connection.check_output( | ||
f"zypper --non-interactive in {'python3' if version.startswith('3.6') else 'python311'}-tox && tox --version" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aren't we're now using python313 in Tumbleweed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not yet, python311 is still the default in tumbleweed. we can change this test to enable 3.13 once possible.
Sadly, this is still broken:
|
https://bugzilla.suse.com/show_bug.cgi?id=1232072