Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test the packaged tox version as well #622

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Test the packaged tox version as well #622

wants to merge 1 commit into from

Conversation

dirkmueller
Copy link
Member

@dirkmueller dirkmueller commented Oct 23, 2024

@dirkmueller dirkmueller marked this pull request as draft October 23, 2024 11:14
@dirkmueller dirkmueller marked this pull request as ready for review October 30, 2024 15:49
Comment on lines 138 to 141
@pytest.mark.xfail(
OS_VERSION in ("15.6", "15.7"),
reason="https://bugzilla.suse.com/show_bug.cgi?id=1232072",
)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The xfail doesn't appear to be valid for SP6

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is valid for SP6, that's where the bug is. the issue is that it is only valid for the python 3.6 version not the python 3.11 version of tox.

I don't know how to express that in an mark.xfail, so for now I've removed the condition. the underlying bug is in progress of being fixed, so with some luck it is released before the next review of this PR happens.

Copy link
Collaborator

@dcermak dcermak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to merge once the CI is green

pytest.skip("packaged tox not available")

auto_container_per_test.connection.check_output(
f"zypper --non-interactive in {'python3' if version.startswith('3.6') else 'python311'}-tox && tox --version"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aren't we're now using python313 in Tumbleweed?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not yet, python311 is still the default in tumbleweed. we can change this test to enable 3.13 once possible.

@dcermak
Copy link
Collaborator

dcermak commented Nov 26, 2024

Sadly, this is still broken:

Traceback (most recent call last):
  File "/usr/lib/python3.6/site-packages/pkg_resources/__init__.py", line 583, in _build_master
    ws.require(__requires__)
  File "/usr/lib/python3.6/site-packages/pkg_resources/__init__.py", line 900, in require
    needed = self.resolve(parse_requirements(requirements))
  File "/usr/lib/python3.6/site-packages/pkg_resources/__init__.py", line 791, in resolve
    raise VersionConflict(dist, req).with_context(dependent_req)
pkg_resources.ContextualVersionConflict: (filelock 3.0.12 (/usr/lib/python3.6/site-packages), Requirement.parse(\'filelock<4,>=3.4.1\'), {\'virtualenv\'})

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/usr/bin/tox", line 6, in <module>
    from pkg_resources import load_entry_point
  File "/usr/lib/python3.6/site-packages/pkg_resources/__init__.py", line 3251, in <module>
    @_call_aside
  File "/usr/lib/python3.6/site-packages/pkg_resources/__init__.py", line 3235, in _call_aside
    f(*args, **kwargs)
  File "/usr/lib/python3.6/site-packages/pkg_resources/__init__.py", line 3264, in _initialize_master_working_set
    working_set = WorkingSet._build_master()
  File "/usr/lib/python3.6/site-packages/pkg_resources/__init__.py", line 585, in _build_master
    return cls._build_from_requirements(__requires__)
  File "/usr/lib/python3.6/site-packages/pkg_resources/__init__.py", line 598, in _build_from_requirements
    dists = ws.resolve(reqs, Environment())
  File "/usr/lib/python3.6/site-packages/pkg_resources/__init__.py", line 786, in resolve
    raise DistributionNotFound(req, requirers)
pkg_resources.DistributionNotFound: The \'filelock<4,>=3.4.1\' distribution was not found and is required by virtualenv
')

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants