Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Further decouple team urn from teams #1306

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

johanib
Copy link
Contributor

@johanib johanib commented Nov 7, 2024

Creating a service no longer generates a teamname urn

Prior to this change, a teamname urn would be created by sp-dashboard.
This feature has been delegated to Invite.
This change removes the code needed to create a new urn.

See #1167
See #1305

Prior to this change, the Service was registered in teams, which is
going to be removed.
This change registers the Service as a role in Invite, so an invite can
be sent later.

See https://www.pivotaltracker.com/story/show/188011488
@johanib johanib force-pushed the feature/1305-decouple-teamname branch from 46fae6a to ce56d9d Compare November 7, 2024 12:34
@johanib johanib marked this pull request as ready for review November 7, 2024 12:34
Prior to this change, a teamname urn would be created by sp-dashboard.
This feature has been delegated to Invite.
This change removes the code needed to create a new urn.

Also remove the Urn validation on Service edit, because it's out of
place in the new way of working.

See #1305
See #1167
@johanib johanib force-pushed the feature/1305-decouple-teamname branch from ce56d9d to f479615 Compare November 11, 2024 10:10
@johanib johanib linked an issue Nov 11, 2024 that may be closed by this pull request
@johanib johanib force-pushed the feature/1400064-create-invite branch from 9b26483 to 75b7ce6 Compare November 11, 2024 13:14
Base automatically changed from feature/1400064-create-invite to main November 12, 2024 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Further decouple team urn from teams
1 participant