Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migreer aanmaken teams van teams naar invite #1167

Closed
phavekes opened this issue Oct 30, 2024 · 0 comments · Fixed by #683
Closed

Migreer aanmaken teams van teams naar invite #1167

phavekes opened this issue Oct 30, 2024 · 0 comments · Fixed by #683
Assignees
@johanib
Labels
Imported invitemigratie

Comments

@phavekes
Copy link
Member

This issue is imported from pivotal - Originaly created at Jul 25, 2024 by Bart Geesink

Bij het aanmaken van een service wordt een team aangemaakt.
Graag deze migeren naar invite. De user 'spdashboard' met wachtwoord 'secret' heeft in de devconf omgeving toegang tot de invite api. Documentatie voor invite staat hier:
https://openconext.github.io/OpenConext-Invite/
De swagger ui staat hier:
https://invite.test2.surfconext.nl/ui/swagger-ui/index.html

Aanmaken van een rol gaat als volgt:
https://invite.test2.surfconext.nl/ui/swagger-ui/index.html#/internal-invite-controller/newRole_1

De inhoud van het aanmaken van de rol:

{
  "name": "$name orgname ",
  "shortName": "$name orgname",
  "description": "SPdashboard access for the service $name of $orgname",
  "defaultExpiryDays": 365,
  "applicationUsages": [
    {
      "landingPage": "https://$spdashboardurl",
      "application": {
        "manageId": "$id_spd_in_manage",
        "manageType": "SAML20_SP"
      }
    }
  ]
}

Met de volgende variabelen:
$name: Naam die in het veld "name" wordt ingevuld
$orgname: Naam die in het veld "Organization name English" wordt ingevuld
$spdashboardurl is de url van het spdashboard zelf
$id_spd_in_manage is het id van het spdashboard in manage.

In het antwoord komt een id en een urn terug. Zie de reponse in de swagger ui. Die ID hebben we nodig en moet ook worden opgeslagen. De URN hoeven we niet meer zelf aan te maken, die wordt door invite bepaald. We moeten deze wel opslaan.

Als de rolnaam bestaat krijg je een HTTP 409. Die moet je afvangen, en suggereren dat de naam wordt aangepast omdat deze al bestaat.
@phavekes phavekes assigned phavekes and unassigned phavekes Oct 30, 2024
@johanib johanib self-assigned this Oct 31, 2024
@johanib johanib linked a pull request Nov 6, 2024 that will close this issue
Create role in invite when registering new service #683
Merged
johanib added a commit that referenced this issue Nov 6, 2024
@johanib
Creating a service no longer generates a teamname urn
dc12710 
Prior to this change, a teamname urn would be created by sp-dashboard.
This feature has been delegated to Invite.
This change removes the code needed to create a new urn.

See #1167
johanib added a commit that referenced this issue Nov 7, 2024
@johanib
Creating a service no longer generates a teamname urn
01f2e93 
Prior to this change, a teamname urn would be created by sp-dashboard.
This feature has been delegated to Invite.
This change removes the code needed to create a new urn.

See #1167
@johanib johanib mentioned this issue Nov 7, 2024
Closed
johanib added a commit that referenced this issue Nov 7, 2024
@johanib
Creating a service no longer generates a teamname urn
bc7964a 
Prior to this change, a teamname urn would be created by sp-dashboard.
This feature has been delegated to Invite.
This change removes the code needed to create a new urn.

See #1167
@johanib johanib mentioned this issue Nov 7, 2024
Open
johanib added a commit that referenced this issue Nov 7, 2024
@johanib
Creating a service no longer generates a teamname urn
46fae6a 
Prior to this change, a teamname urn would be created by sp-dashboard.
This feature has been delegated to Invite.
This change removes the code needed to create a new urn.

See #1167
@johanib johanib mentioned this issue Nov 7, 2024
Open
johanib added a commit that referenced this issue Nov 7, 2024
@johanib
Creating a service no longer generates a teamname urn
ce56d9d 
Prior to this change, a teamname urn would be created by sp-dashboard.
This feature has been delegated to Invite.
This change removes the code needed to create a new urn.

See #1305
See #1167
johanib added a commit that referenced this issue Nov 11, 2024
@johanib
Creating a service no longer generates a teamname urn
f479615 
Prior to this change, a teamname urn would be created by sp-dashboard.
This feature has been delegated to Invite.
This change removes the code needed to create a new urn.

Also remove the Urn validation on Service edit, because it's out of
place in the new way of working.

See #1305
See #1167
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@johanib johanib

Labels
Imported invitemigratie
Projects
sp-dashboard
Status: Delivered
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Create role in invite when registering new service SURFnet/sp-dashboard
2 participants
@phavekes @johanib