PathnameEnvironment usable in non-html5 history api browser; falls back on window.location.pathname #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ck on window.location.pathname
|
Thanks a lot for this. |
STRML
added a commit
that referenced
this pull request
Jan 20, 2015
PathnameEnvironment usable in non-html5 history api browser; falls back on window.location.pathname
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is related to issue #110, though it is not a complete solution. If you force the Environment to PathnameEnvironment but
window.historyisn't available, it will fall back on just settingwindow.location.pathname. This allows old browsers like IE9 to use modern routes with minimal effort, gracefully falling back to a normal page reload when the history api isn't available.Personally, I think this should be the default behavior unless
hash={true}is specified, but that is up to the authors. A change like that would also require thinking more about the relationship between pathname and hash routing, and the problems of sharing routes between both sides. This is mentioned here as well: #99This pull request should be safe for backwards compatibility, as it only changes behavior for people explicitly setting the environment to use to
PathnameEnvironment, a case which prior to this pull request simply throws an exception in IE9.