Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Fiddaman 2023 #1198

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Added Fiddaman 2023 #1198

wants to merge 8 commits into from

Conversation

aidaanva
Copy link
Contributor

@aidaanva aidaanva commented Oct 4, 2024

Pull Request

This PR is for a

For the following list(s):

  • ancientmetagenome-environmental (README)
  • ancientmetagenome-hostassociated (README)
  • ancientsinglegenome-hostassociated (README)

This is to close #1130

PR Workflow

  1. Open this PR with sample metadata on the samples metadata sheet (:tada: you're already here!)
  2. Wait for checks for sample metdata to pass
  3. (If checks fail) make corrections, and push changes to this branch (no need to open a new PR!)
  4. (Once passed) comment on this PR @spaam-bot please autofill <table_name> <project_id> to get a half-filled template! (may take a minute or so to get the comment with the file)
  5. Fill in the template, and verify autofilled data correct!
  6. Once filled in, append(!) the new rows from the TEMPLATE file to the end of the corresponding library metadata file, and update this PR
  7. Wait for checks for library metadata to pass
  8. Request review!

Pre-review checklist (new publications)

  • Publication is published
    • Preprints currently not accepted?
  • Checked the publication is not already in the database?
  • Checked samples in this publication are not previously published data?
    • Newly re-sequenced metagenomes are OK!
  • Samples are shotgun metagenomes and not amplicon data
    • Note: hostassociated-singlegenome may also contain whole-genome enriched data
  • Checked the list follows conventions as described in the corresponding sample type's README file (e.g. using ERS/SRS accession codes for ENA/SRA)?
  • Once sample table validation completed Library metadata has been added
    • Use @spaam-bot please autofill <table_name> <project_id> to get a half-filled template! May take a minute or so to get the comment with the file
    • Fill in template, and verify autofill data correct!
    • Once filled in, append(!) the new rows to the end of the corresponding library metadata file
  • Changelog is updated to include the publication under 'Added'?

@aidaanva
Copy link
Contributor Author

aidaanva commented Oct 4, 2024

Need to modify enums, check #1200 and #1199

@jfy133 jfy133 force-pushed the master branch 3 times, most recently from 49ac494 to 62f90dc Compare October 5, 2024 04:40
@aidaanva
Copy link
Contributor Author

@spaam-bot please autofill ancientsinglegenome-hostassociated_libraries.tsv Fiddaman2023

@aidaanva
Copy link
Contributor Author

@spaam-bot please autofill ancientsinglegenome-hostassociated Fiddaman2023

@aidaanva aidaanva changed the title Added Fiddaman 2023 sample table Added Fiddaman 2023 Nov 11, 2024
@aidaanva aidaanva requested a review from alexhbnr November 12, 2024 08:39
@aidaanva aidaanva added singlegenome-hostassociated Samples with ancient whole (single) genome microbial species virus Ready for Review labels Nov 12, 2024
Copy link

github-actions bot commented Jan 1, 2025

AMDirT, version 1.6.2

Samples

Ancient Metagenome Host Associated

ancientmetagenome-hostassociated_samples.tsv is valid

Ancient Single Genome Host Associated

ancientsinglegenome-hostassociated_samples.tsv is valid

Ancient Metagenome Environmental

ancientmetagenome-environmental_samples.tsv is valid

Libraries

Ancient Metagenome Host Associated

ancientmetagenome-hostassociated_libraries.tsv is valid

Ancient Single Genome Host Associated

ancientsinglegenome-hostassociated_libraries.tsv is valid

Ancient Metagenome Environmental

ancientmetagenome-environmental_libraries.tsv is valid

Copy link
Collaborator

@alexhbnr alexhbnr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, however, I converted the sample ages from CE to BP.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready for Review singlegenome-hostassociated Samples with ancient whole (single) genome microbial species virus
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fiddaman 2023
2 participants