Add optional builder pattern to OpenAPI mustache POJO template #508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
newtork
added
do not merge
newtork
changed the title
@Nonnull / @Nullable annotation to OpenAPI generated model classes
newtork
changed the title
…to annotation-openapi-generator
newtork
added
please merge
CharlesDuboisSAP
previously requested changes
Jul 29, 2024
...ain/java/com/sap/cloud/sdk/datamodel/openapi/generator/GenerationConfigurationConverter.java
Outdated
Show resolved
Hide resolved
...ain/java/com/sap/cloud/sdk/datamodel/openapi/generator/GenerationConfigurationConverter.java
Outdated
Show resolved
Hide resolved
...napi/openapi-generator/src/main/resources/openapi-generator/mustache-templates/pojo.mustache
Outdated
Show resolved
Hide resolved
...enapi-generator/src/main/resources/openapi-generator/mustache-templates/pojoBuilder.mustache
Outdated
Show resolved
Hide resolved
newtork
commented
Jul 29, 2024
Comment on lines
+341
to
+356
| /** | ||
| * Set the flavors of this {@link Soda} instance. | ||
| * | ||
| * @param flavors The flavors of this {@link Soda} | ||
| * @return The Soda builder. | ||
| */ | ||
| Builder3 flavors( @Nonnull final List<String> flavors); | ||
| /** | ||
| * Set the flavors of this {@link Soda} instance. | ||
| * | ||
| * @param flavors The flavors of this {@link Soda} | ||
| * @return The Soda builder. | ||
| */ | ||
| default Builder3 flavors( @Nonnull final String... flavors) { | ||
| return flavors(Arrays.asList(flavors)); | ||
| } |
There was a problem hiding this comment.
@CharlesDuboisSAP here I added a test case for builder feature. We do longer need to rely on the sample module.
CharlesDuboisSAP
approved these changes
Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some improvements on the POJO classes generated for OpenAPI specifications.
@Nonnulland@Nullableon fields. We already had them on the regular accessors.<additionalProperties>, e.g. to match Lombok style:<pojoBuilderMethodName>builder</pojoBuilderMethodName>(when empty -> disabled)<pojoBuildMethodName>build</pojoBuilderMethodName>(when empty -> implicit instantiation)<pojoConstructorVisibility>public</pojoConstructorVisibility>(when empty -> no explicit constructor)For AI project we consider to use
builderMethodName="create"buildMethodName=""pojoConstructorVisibility="protected"(I couldn't find an easy way to omit empty lines being added. It seems to be a side effect of
{{>pojoBuilder}})