Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow process_response and process_slo to raise is_valid exceptions #393

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rwlogel
Copy link

@rwlogel rwlogel commented Feb 8, 2024

It is nice to be able to see the actual is_valid exception so you know exactly what line it was raised on in the validation code. This is helpful in determining exactly what rule was broken and if it is possible to disable that check.

Currently the raise_exceptions is a useful feature that isn't really accessible to the caller unless they make their own response object.

This feature was requested in the old project before it was retired. SAML-Toolkits/python-saml#253

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant