Apply clock drift to SubjectConfirmationData and AuthnStatement #385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pitbulk
approved these changes
Feb 8, 2024
|
@pitbulk Can this be merged? |
|
@pitbulk Can this be merged? |
…-SubjectConfirmationData
tvuotila
deleted the
feature/apply-clock-drift-to-SubjectConfirmationData
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was debugging SAML response with arbitrarily large
ALLOWED_CLOCK_DRIFT. I noticed that it didn't apply to all timestamp values. This PR makes theALLOWED_CLOCK_DRIFTto apply to more values.Should I add some tests for this? What kind of tests are needed?