Recording the serial interval #267
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #267 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 110 110
Lines 3876 3927 +51
=========================================
+ Hits 3876 3927 +51 ☔ View full report in Codecov by Sentry. |
|
@mghosh00 just following up on this so the repo is up to date for publication - how much of this is actually intended to go onto main? For example I see the (untested) triple sweep work here, which I assume was just a simple debugging test and so will not actually be merged into the main repo. If this is the case, it could be more appropriate to close the PR, and perhaps delete the branch if we do not now need this code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I have added the ability to record serial intervals of all infection events (which can be used to generate a distribution of serial intervals). The output of this is in a file named serial_intervals.csv.
Checklist
All new functions have docstrings in the correct style
I've verified the complete docs build locally without errors
I've maintained 100% coverage (please mention any 'no cover' annotations explicitly)
I've unit-tested all new methods directly
Breaking change (fix or feature that would cause existing functionality to change)
I have read the CONTRIBUTING document.
My code follows the code style of this project.
I have updated the wiki with new parameters/model functionality
Closing issues
Closes #262