-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reviewer comments #257
Reviewer comments #257
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #257 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 108 108
Lines 3690 3690
=========================================
Hits 3690 3690 ☔ View full report in Codecov by Sentry. |
…demiology/epiabm into reviewer-comments-KG
…demiology/epiabm into reviewer-comments-KG
…demiology/epiabm into reviewer-comments-KG
…demiology/epiabm into reviewer-comments-KG
…demiology/epiabm into reviewer-comments-KG
…demiology/epiabm into reviewer-comments-KG
…demiology/epiabm into reviewer-comments-KG
…demiology/epiabm into reviewer-comments-KG
…demiology/epiabm into reviewer-comments-KG
…demiology/epiabm into reviewer-comments-KG
…demiology/epiabm into reviewer-comments-KG
…demiology/epiabm into reviewer-comments-KG
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks really good, we are just getting a broken link on the cEpiabm readthedocs
... inserting link_libraries(stdc++fs) in [CMakeLists.txt](cEpiabmCMakeLists.txt).
Co-authored-by: rccreswell <[email protected]>
Co-authored-by: NicholasFan235 <[email protected]>
Co-authored-by: rccreswell <[email protected]>
Changes from reviewer comments
(N.B This last change means the files on main do not match the paths expected by ReadTheDocs. However I have tested the new branches, and it builds successfully when redirected there, so this should be resolved once on main).