-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compression of infection history csv files #252
Conversation
…iology/epiabm into infection-history
…piabm into infection-history
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #252 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 108 108
Lines 3651 3671 +20
=========================================
+ Hits 3651 3671 +20 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work, and some really nice testing! A few small changes, and some suggestions about the kinds of files we want to merge onto main (avoiding large or binary files).
pyEpiabm/pyEpiabm/tests/test_unit/test_routine/test_simulation.py
Outdated
Show resolved
Hide resolved
pyEpiabm/pyEpiabm/tests/test_unit/test_routine/test_simulation.py
Outdated
Show resolved
Hide resolved
python_examples/basic_infection_history_simulation/simulation_outputs/inf_status_history.gz
Outdated
Show resolved
Hide resolved
python_examples/gibraltar_example/simulation_outputs/with_intervention/demographics.csv
Outdated
Show resolved
Hide resolved
python_examples/gibraltar_example/simulation_outputs/without_intervention/demographics.csv
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work - especially on some difficult mocking in the tests!
python_examples/basic_infection_history_simulation/simulation_flow.py
Outdated
Show resolved
Hide resolved
…flow.py Co-authored-by: Kit Gallagher <[email protected]>
Summary
Checklist
All new functions have docstrings in the correct style
I've verified the complete docs build locally without errors
I've maintained 100% coverage (please mention any 'no cover' annotations explicitly)
I've unit-tested all new methods directly
Breaking change (fix or feature that would cause existing functionality to change)
I have read the CONTRIBUTING document.
My code follows the code style of this project.
I have updated the wiki with new parameters/model functionality
Closing issues
Closes #250