Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compression of infection history csv files #252

Merged
merged 22 commits into from
Jan 24, 2024
Merged

Conversation

abbie-evans
Copy link
Contributor

@abbie-evans abbie-evans commented Jan 23, 2024

Summary

  • Use a compression method to reduce the storage space
  • Be able to compress to and extract from zip csv files
  • Enable the compression to be activated and deactivated
  • Ran on two example simulations

Checklist

  • All new functions have docstrings in the correct style

  • I've verified the complete docs build locally without errors

  • I've maintained 100% coverage (please mention any 'no cover' annotations explicitly)

  • I've unit-tested all new methods directly

  • Breaking change (fix or feature that would cause existing functionality to change)

  • I have read the CONTRIBUTING document.

  • My code follows the code style of this project.

  • I have updated the wiki with new parameters/model functionality

Closing issues

Closes #250

Copy link

codecov bot commented Jan 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (04ccb52) 100.00% compared to head (6bef0ec) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #252   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          108       108           
  Lines         3651      3671   +20     
=========================================
+ Hits          3651      3671   +20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@KCGallagher KCGallagher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, and some really nice testing! A few small changes, and some suggestions about the kinds of files we want to merge onto main (avoiding large or binary files).

Copy link
Contributor

@KCGallagher KCGallagher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work - especially on some difficult mocking in the tests!

@abbie-evans abbie-evans merged commit bef7687 into main Jan 24, 2024
15 checks passed
@abbie-evans abbie-evans deleted the infection-history branch February 9, 2024 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compression of csv files
2 participants