Csv writing #249
Merged
Csv writing #249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…piabm into infection-history
…ord infection history or not)
…piabm into infection-history
…piabm into infection-history
…piabm into infection-history
…n-history # Conflicts: # pyEpiabm/pyEpiabm/sweep/update_place_sweep.py
…n-history # Conflicts: # pyEpiabm/pyEpiabm/sweep/update_place_sweep.py
mghosh00
reviewed
Dec 6, 2023
mghosh00
reviewed
Dec 6, 2023
mghosh00
reviewed
Dec 6, 2023
KCGallagher
requested changes
Dec 9, 2023
KCGallagher
requested changes
Jan 10, 2024
There was a problem hiding this comment.
One minor suggestion for some logic I don't quite understand (nested if statements - there are two examples in the same file), but otherwise am happy with this. Afraid I want to postpone merging until we resolve the functional test issue, but I will look into this tonight/tomorrow and decide what to do here.
KCGallagher
approved these changes
Jan 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Checklist
All new functions have docstrings in the correct style
I've verified the complete docs build locally without errors
I've maintained 100% coverage (please mention any 'no cover' annotations explicitly)
I've unit-tested all new methods directly
Breaking change (fix or feature that would cause existing functionality to change)
I have read the CONTRIBUTING document.
My code follows the code style of this project.
I have updated the wiki with new parameters/model functionality
Closing issues
Closes #248.