Feature #247
Merged
Feature #247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #247 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 105 105
Lines 3380 3427 +47
=========================================
+ Hits 3380 3427 +47 ☔ View full report in Codecov by Sentry. |
KCGallagher
requested changes
Nov 22, 2023
pyEpiabm/pyEpiabm/tests/test_unit/test_routine/test_file_population_config.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Kit Gallagher <[email protected]>
KCGallagher
approved these changes
Nov 22, 2023
…ot already have household
…n control when the id of a person is changed
# Conflicts: # pyEpiabm/pyEpiabm/core/microcell.py
KCGallagher
requested changes
Nov 30, 2023
Co-authored-by: Kit Gallagher <[email protected]>
… to determine whether we want the id overridden or not
KCGallagher
requested changes
Nov 30, 2023
pyEpiabm/pyEpiabm/tests/test_unit/test_intervention/test_travel_isolation.py
Outdated
Show resolved
Hide resolved
KCGallagher
approved these changes
Nov 30, 2023
There was a problem hiding this comment.
Brilliant work @mghosh00 and @abbie-evans on this PR - thanks for your perseverance on this and all the hard work to get this finished! I am very happy with this addition, and you both adapted well to the issues coding this up that I had not anticipated, particularly regarding travel isolation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Created ids for Person and Household, and changed the Cell and Microcell ids to be strings
Checklist
All new functions have docstrings in the correct style
I've verified the complete docs build locally without errors
I've maintained 100% coverage (please mention any 'no cover' annotations explicitly)
I've unit-tested all new methods directly
Breaking change (fix or feature that would cause existing functionality to change)
I have read the CONTRIBUTING document.
My code follows the code style of this project.
I have updated the wiki with new parameters/model functionality
Closing issues
Closes #242 .