Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add base citation file (#245) #246

Merged
merged 2 commits into from
Nov 21, 2023
Merged

Add base citation file (#245) #246

merged 2 commits into from
Nov 21, 2023

Conversation

KCGallagher
Copy link
Contributor

Added citation file for github compatibility.
Based on zenodo repo v1.1.0, but also includes link to arxiv.
May add JOSS paper once published

Closes #245

@KCGallagher KCGallagher added the documentation Improvements or additions to documentation label Nov 21, 2023
@KCGallagher KCGallagher self-assigned this Nov 21, 2023
Copy link

codecov bot commented Nov 21, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (df3dc4f) 100.00% compared to head (df74c26) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #246   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          105       105           
  Lines         3380      3380           
=========================================
  Hits          3380      3380           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@laraherriott laraherriott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to leave as is but we could also update the affiliations from my year to be the current departments in line with those for everyone else? Also the author order seems a bit random (though you may have had reasons to do it in this way) - I'm not sure how much it matters but these files can be pulled into Zotero which would import the author order as given here.

@I-Bouros
Copy link
Contributor

Happy to leave as is but we could also update the affiliations from my year to be the current departments in line with those for everyone else? Also the author order seems a bit random (though you may have had reasons to do it in this way) - I'm not sure how much it matters but these files can be pulled into Zotero which would import the author order as given here.

I think it reflects the order of contribution on the main code page. I am happy as well to leave as is or change it.

@KCGallagher
Copy link
Contributor Author

Happy to leave as is but we could also update the affiliations from my year to be the current departments in line with those for everyone else? Also the author order seems a bit random (though you may have had reasons to do it in this way) - I'm not sure how much it matters but these files can be pulled into Zotero which would import the author order as given here.

I think it reflects the order of contribution on the main code page. I am happy as well to leave as is or change it.

This is exactly the case! I am not sure how else to do it - we have two papers but they do not have the same authorship list/order, so there is no easy way to come up with one consistent order. Happy to hear alternative suggestions here though?

@KCGallagher KCGallagher merged commit 0948f45 into main Nov 21, 2023
15 checks passed
@KCGallagher KCGallagher deleted the kcgallagher-citation-file branch November 21, 2023 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Citation file
3 participants