Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #241

Merged
merged 1 commit into from
Oct 5, 2023
Merged

Update README.md #241

merged 1 commit into from
Oct 5, 2023

Conversation

njs59
Copy link
Contributor

@njs59 njs59 commented Oct 5, 2023

Summary

Describe the issue, and what you have done to solve it

Further work

If relevant, add in what needs to be done next on this area (and whether you will do it!)

Checklist

  • All new functions have docstrings in the correct style

  • I've verified the complete docs build locally without errors

  • I've maintained 100% coverage (please mention any 'no cover' annotations explicitly)

  • I've unit-tested all new methods directly

  • Breaking change (fix or feature that would cause existing functionality to change)

  • I have read the CONTRIBUTING document.

  • My code follows the code style of this project.

  • I have updated the wiki with new parameters/model functionality

Closing issues

Put closes #XXXX in your comment to auto-close the issue that your PR fixes (if such).

@njs59 njs59 requested a review from KCGallagher October 5, 2023 10:21
@codecov
Copy link

codecov bot commented Oct 5, 2023

Codecov Report

Merging #241 (4ac95ec) into main (145ab32) will not change coverage.
The diff coverage is n/a.

❗ Current head 4ac95ec differs from pull request most recent head f05d611. Consider uploading reports for the commit f05d611 to get more accurate results

@@             Coverage Diff             @@
##              main      #241     +/-   ##
===========================================
  Coverage   100.00%   100.00%             
===========================================
  Files          105        47     -58     
  Lines         3380      1122   -2258     
===========================================
- Hits          3380      1122   -2258     

see 58 files with indirect coverage changes

@njs59 njs59 merged commit c304f36 into main Oct 5, 2023
15 checks passed
@njs59 njs59 deleted the Nathan-README branch October 5, 2023 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants