Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toy interventions notebook #238

Merged
merged 46 commits into from
Oct 2, 2023
Merged

Toy interventions notebook #238

merged 46 commits into from
Oct 2, 2023

Conversation

HenrietteCapel
Copy link
Contributor

Summary

This notebook, with corresponding input files, shows how to compare a single intervention with different parameters and multiple interventions.

Further work

If relevant, add in what needs to be done next on this area (and whether you will do it!)

Checklist

  • All new functions have docstrings in the correct style

  • I've verified the complete docs build locally without errors

  • I've maintained 100% coverage (please mention any 'no cover' annotations explicitly)

  • I've unit-tested all new methods directly

  • Breaking change (fix or feature that would cause existing functionality to change)

  • I have read the CONTRIBUTING document.

  • My code follows the code style of this project.

  • I have updated the wiki with new parameters/model functionality

Closing issues

Put closes #XXXX in your comment to auto-close the issue that your PR fixes (if such).

HenrietteCapel and others added 30 commits March 16, 2023 12:46
Merge branch 'main' into toy-interventions
@codecov
Copy link

codecov bot commented Oct 1, 2023

Codecov Report

Merging #238 (5939d46) into main (8a29609) will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff             @@
##              main      #238     +/-   ##
===========================================
  Coverage   100.00%   100.00%             
===========================================
  Files          105        58     -47     
  Lines         3380      2258   -1122     
===========================================
- Hits          3380      2258   -1122     

see 47 files with indirect coverage changes

Copy link
Contributor

@KCGallagher KCGallagher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Please just add a small description of the new examples folders in the python examples readme (python_examples\README.md) - we've got a little behind on this but it would be good to have a sentence or two briefly summarizing each sub folder, so users can find the one they are interested in. Happy to pre-approve on the basis that you do this though, so you can merge when you've done that

@HenrietteCapel HenrietteCapel merged commit 145ab32 into main Oct 2, 2023
15 checks passed
@HenrietteCapel HenrietteCapel deleted the toy-interventions branch October 2, 2023 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants