Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NZ simulation params #232

Merged
merged 6 commits into from
Sep 28, 2023
Merged

NZ simulation params #232

merged 6 commits into from
Sep 28, 2023

Conversation

jiayuanz3
Copy link
Contributor

Summary

New Zealand parameters to run the simulation.

@codecov
Copy link

codecov bot commented Sep 28, 2023

Codecov Report

Merging #232 (3438f1f) into main (0f08524) will not change coverage.
The diff coverage is n/a.

❗ Current head 3438f1f differs from pull request most recent head 0177737. Consider uploading reports for the commit 0177737 to get more accurate results

@@             Coverage Diff             @@
##              main      #232     +/-   ##
===========================================
  Coverage   100.00%   100.00%             
===========================================
  Files          105        47     -58     
  Lines         3380      1122   -2258     
===========================================
- Hits          3380      1122   -2258     

see 58 files with indirect coverage changes

Copy link
Contributor

@KCGallagher KCGallagher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That New Zealand input file is massive! I think if we have the script to generate this (or instructions and a link to epigeopop) then we don't need to add this as well - you could put it in the .gitignore instead so you don't have to delete it off your local machine

python_examples/NZ_example/NZ_flow.py Outdated Show resolved Hide resolved
@jiayuanz3
Copy link
Contributor Author

That New Zealand input file is massive! I think if we have the script to generate this (or instructions and a link to epigeopop) then we don't need to add this as well - you could put it in the .gitignore instead so you don't have to delete it off your local machine

I've added the input file to .gitignore. Where should I mention the link to use epigeopop to generate this file (p.s. Isaac is working on the script/bash file to generate input files)?

@KCGallagher KCGallagher merged commit fa01f97 into main Sep 28, 2023
15 checks passed
@KCGallagher KCGallagher deleted the NZ-param branch September 28, 2023 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants