Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toy spatial #225

Merged
merged 22 commits into from
Sep 27, 2023
Merged

Toy spatial #225

merged 22 commits into from
Sep 27, 2023

Conversation

laraherriott
Copy link
Contributor

Summary

Example notebook to demonstrate the generation of approximately uniform populations and show the comparison of epidemics in different density examples.

Further work

Similar notebook to be constructed to demonstrate the application of interventions

@codecov
Copy link

codecov bot commented Sep 26, 2023

Codecov Report

Merging #225 (89f3326) into main (614f503) will not change coverage.
The diff coverage is n/a.

❗ Current head 89f3326 differs from pull request most recent head d01dd41. Consider uploading reports for the commit d01dd41 to get more accurate results

@@             Coverage Diff             @@
##              main      #225     +/-   ##
===========================================
  Coverage   100.00%   100.00%             
===========================================
  Files          105        47     -58     
  Lines         3380      1122   -2258     
===========================================
- Hits          3380      1122   -2258     

see 58 files with indirect coverage changes

Copy link
Contributor

@KCGallagher KCGallagher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, really nice plots! One tiny comment, but I'm happy to pre-approve this on the basis that you add that

" location_x.append(x)\n",
" location_y.append(y)\n",
"\n",
"new_susceptible = susceptible[:-(total_population - sum(susceptible))]+[x + 1 for x in susceptible[-(total_population - sum(susceptible)):]]\n",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't find this line very intuitive - it might be fine in a codebase (although I am not sure), but in an exemplar notebook it should definitely be commented to explain what you are doing here!

@laraherriott laraherriott merged commit a7749b5 into main Sep 27, 2023
15 checks passed
@KCGallagher KCGallagher deleted the toy-spatial branch September 28, 2023 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants