fixes RP2040 build #47
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes compiler errors for RP2040 by disabling the setting storage feature by now. Must be implemented later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes issue #46 by disabling EEPROM / setting storage support for RP2040 boards for now. The build does not work at all / fails. The feature must be added for RP2040 boards later on.
RP2040 boards do not come with a build in EEPROM. But the Arduino EEPROM library in general does support those boards thought. They use some Flash storage to emulate the EEPROM. But it's not recommended to do it this way, because Flash storage wears out quicker than an EEPROM does.
Preferred way would be, to add an SD-Card Reader for storing the settings. For this, some generic setting handler / adapter / plugin handler would be required.