Skip to content

Commit

Permalink
refactor: move type:check to lint hook- Removed type:check from prete…
Browse files Browse the repository at this point in the history
…st, build, and postbuild scripts- Added type checking to lint command- Improves development speed by reducing redundant type checksFixes FuelLabs#3248
  • Loading branch information
Rohit-Bhetal committed Nov 11, 2024
1 parent 62b5607 commit 4d67d8f
Show file tree
Hide file tree
Showing 5 changed files with 8 additions and 10 deletions.
3 changes: 2 additions & 1 deletion apps/docs-snippets/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,8 @@
"description": "",
"private": true,
"scripts": {
"pretest": "./scripts/pretest.sh"
"pretest": "./scripts/pretest.sh",
"lint": "tsc --noEmit"
},
"devDependencies": {
"@fuel-ts/account": "workspace:*",
Expand Down
3 changes: 0 additions & 3 deletions apps/docs-snippets/scripts/pretest.sh
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,3 @@ pnpm fuels build

# Deploys projects (needed for loader bytecode)
pnpm fuels deploy

# Checks for type errors
pnpm tsc --noEmit
4 changes: 2 additions & 2 deletions internal/benchmarks/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@
"dist"
],
"scripts": {
"type:check": "tsc --noEmit",
"pretest": "run-s build:forc type:check",
"lint": "tsc --noEmit",
"pretest": "run-s build:forc ",
"build:forc": "pnpm fuels build"
},
"license": "Apache-2.0",
Expand Down
4 changes: 2 additions & 2 deletions packages/create-fuels/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,9 @@
},
"license": "Apache-2.0",
"scripts": {
"build": "run-s build:source type:check",
"build": "run-s build:source",
"build:source": "tsup",
"type:check": "tsc --noEmit",
"lint": "tsc --noEmit",
"prepublishOnly": "tsx ./scripts/prepublish.ts"
},
"dependencies": {
Expand Down
4 changes: 2 additions & 2 deletions packages/fuel-gauge/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,10 @@
"description": "",
"author": "Fuel Labs <[email protected]> (https://fuel.network/)",
"scripts": {
"pretest": "run-s build:forc build:process-predicates type:check",
"pretest": "run-s build:forc build:process-predicates",
"build:forc": "pnpm fuels build",
"build:process-predicates": "tsx ./scripts/process-predicates.ts",
"type:check": "tsc --noEmit"
"lint": "tsc --noEmit"
},
"license": "Apache-2.0",
"dependencies": {
Expand Down

0 comments on commit 4d67d8f

Please sign in to comment.