-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(fuselage): Responsive CardControls
#1443
base: main
Are you sure you want to change the base?
fix(fuselage): Responsive CardControls
#1443
Conversation
Horizontal cards should have flex-wrap only for mobile view
🦋 Changeset detectedLatest commit: e2a79ef The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Box is not needed. A better way would be to use the mixin for conditional css. Co-authored-by: Henrique Guimarães Ribeiro <[email protected]>
Co-authored-by: Henrique Guimarães Ribeiro <[email protected]>
Hey Henrique! I just saw a repetition of code caused by previous commit. I fixed that in the latest commit. Now everything looks fine to me. Can you please check? |
Hey @rique223! All the changes requested by you are done from my side. Let me know if you are looking for something else. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm
CardControls
Co-authored-by: Júlia Jaeger Foresti <[email protected]>
Co-authored-by: Júlia Jaeger Foresti <[email protected]>
Proposed changes (including videos or screenshots)
Added flex-wrap in the CSS of Cards for CardControl component. Things that have been kept in mind are:-
responsive.mov
Issue(s)
Closes #1440 #31614
Further comments
There are other ways to go around it but this felt appropriate and fixes the issue.