Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Quotes render image #6071

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

Rishab87
Copy link

Proposed changes

Images and any other attatchments were not visible in quoted messages

Issue(s)

Fixes #704

How to test or reproduce

Quote any message in channel. I have not added preview of any attatchments as text box is already very small and their can be many attatchments, so feasible solution I thought of is to mention no. of images , audio files etc in the quoted message. If you want I can add preview of first attatchment like a small preview of image but I honestly think that won't look good.

Screenshots

fixquote

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FIX] Replies don't render images
1 participant