Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Encode URI in quotation (message) and channel links #6067

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

3da
Copy link

@3da 3da commented Dec 17, 2024

It fixes links to messages or channels with non ascii characters or spaces.

Proposed changes

Encode URI in quotation (message) and channel links

Issue(s)

How to test or reproduce

  1. Create channel with spaces and non ascii symbols.
  2. Create message.
  3. Quote message.

Screenshots

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

…or channel names with spaces and non ascii characters.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant