Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: support for edge to edge screen in android #6040

Draft
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

Rohit3523
Copy link
Contributor

Proposed changes

This PR introduces support for edge-to-edge rendering on Android as required by API Level 35 (Android 15). With this update, content is adjusted to account for the enforced edge-to-edge behavior that moves it behind the status and navigation bars. The update ensures compatibility with earlier Android versions while adhering to the limitations imposed by Android 15, where setting background colors for the status and navigation bars is no longer supported. These changes may align with the anticipated requirement from Google Play to target API Level 35 by August 31, 2025, based on the trends observed with the last two SDKs.

References

Issue(s)

N/A

How to test or reproduce

N/A

Screenshots

N/A

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

Test is pending for iOS

@Rohit3523 Rohit3523 marked this pull request as draft December 2, 2024 18:47
@@ -178,7 +178,8 @@ class RoomView extends React.Component<IRoomViewProps, IRoomViewState> {
canReturnQueue: false,
canPlaceLivechatOnHold: false,
isOnHold: false,
rightButtonsWidth: 0
rightButtonsWidth: 0,
keyboardVisible: false
Copy link
Contributor Author

@Rohit3523 Rohit3523 Dec 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here i am going to use keyboard hook, temporary using state because hooks are hard to use in class component

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant