chore(a11y): ProfileView #6036
Open
chore(a11y): ProfileView #6036
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OtavioStasiak
force-pushed
the
chore-a11y-profile-view
branch
from
233ca73 to
f92c7b7
Compare
diegolmello
requested changes
Dec 9, 2024
|
|
||
| // https://github.com/RocketChat/Rocket.Chat/blob/174c28d40b3d5a52023ee2dca2e81dd77ff33fa5/apps/meteor/app/lib/server/functions/saveUser.js#L24-L25 | ||
| const MAX_BIO_LENGTH = 260; | ||
| const MAX_NICKNAME_LENGTH = 120; | ||
| const passwordRules = /^(?!.*(.)\1{2})^(?=.*[a-z])(?=.*\d)(?=.*[@$!%*?&])[A-Za-z\d@$!%*?&]{8,24}$/; |
There was a problem hiding this comment.
Where did you get this from?
Password policy are built around admin choices
| }, | ||
| resolver: yupResolver(validationSchema) | ||
| }); | ||
| const parsedCustomFields = getParsedCustomFields(Accounts_CustomFields); |
There was a problem hiding this comment.
Since getParsedCustomFields does a serialization with a try/catch, I think it makes sense to make it a custom hook with useMemo.
The way it is right now, getParsedCustomFields is called on every render, which does a JSON.parse.
You can use useMemo to run these parses only once and a custom hook would remove the need of a getParsedCustomFields file, since you're going to add the whole logic inside useParsedCustomFields file.
| return null; | ||
| } | ||
| try { | ||
| const parsedCustomFields = JSON.parse(Accounts_CustomFields); |
There was a problem hiding this comment.
Same thing.
Just use useParsedCustomFields
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Migrate ProfileView to hooks and Added accessibility features to the RegisterView.
Issue(s)
https://rocketchat.atlassian.net/browse/MA-198
https://rocketchat.atlassian.net/browse/NATIVE-19
How to test or reproduce
Screenshots
Types of changes
Checklist
Further comments