Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: hide autocomplete on send button press #6034

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

Rohit3523
Copy link
Contributor

Proposed changes

This PR fixes an issue where the autocomplete menu for user mentions @ or emojis : does not hide when a message is sent without selecting any suggestion from the menu. The fix ensures that the autocomplete menu is properly dismissed when the message is sent, providing a smoother user experience.

Issue(s)

N/A

How to test or reproduce

  1. Open any channel or direct message.
  2. Type @roh or :smi to trigger the autocomplete menu.
  3. Without selecting any suggestion, press the send button.
  4. Observe the autocomplete menu after sending the message.

Screenshots

Before After
https://github.com/user-attachments/assets/2fb48c4a-575f-491c-87f1-a09a51cb4190 https://github.com/user-attachments/assets/28f040ff-ab69-4b83-8db2-9f97812e5e31

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant