Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(a11y): RegisterView #6027

Open
wants to merge 47 commits into
base: develop
Choose a base branch
from
Open

chore(a11y): RegisterView #6027

wants to merge 47 commits into from

Conversation

OtavioStasiak
Copy link
Contributor

@OtavioStasiak OtavioStasiak commented Nov 27, 2024 •
edited
Loading

Proposed changes

Added accessibility features to the RegisterView.

Issue(s)

https://rocketchat.atlassian.net/browse/MA-197

How to test or reproduce

Screenshots

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

@OtavioStasiak OtavioStasiak changed the title Chore a11y signup chore(a11y): RegisterView Nov 28, 2024
@OtavioStasiak OtavioStasiak force-pushed the chore-a11y-signup branch 2 times, most recently from 54a3059 to 992a622 Compare December 3, 2024 04:00
@OtavioStasiak OtavioStasiak marked this pull request as ready for review December 3, 2024 14:34
diegolmello
diegolmello requested changes Dec 5, 2024
View reviewed changes
app/views/RegisterView/Tip.tsx Outdated Show resolved Hide resolved
app/views/RegisterView/Tip.tsx Show resolved Hide resolved
diegolmello
diegolmello requested changes Dec 9, 2024
View reviewed changes
app/containers/TextInput/FormTextInput.tsx Outdated Show resolved Hide resolved
app/containers/Touch.tsx Outdated Show resolved Hide resolved
app/i18n/locales/en.json Outdated Show resolved Hide resolved
app/lib/constants/colors.ts Outdated Show resolved Hide resolved
app/views/RegisterView/PasswordTips.tsx Outdated Show resolved Hide resolved
app/views/RegisterView/PasswordTips.tsx Outdated Show resolved Hide resolved
app/views/RegisterView/index.tsx Outdated Show resolved Hide resolved
app/views/RegisterView/index.tsx Outdated Show resolved Hide resolved
OtavioStasiak and others added 23 commits December 12, 2024 10:45
@OtavioStasiak
chore: started to migrate to hooks
27d8790
@OtavioStasiak
chore: updated layout
6c1b5cc
@OtavioStasiak
chore: organization of code
bdf065f
@OtavioStasiak
fix: lint
0e5b0b6
@OtavioStasiak
chore: updated accessibility button
d892294
@OtavioStasiak
fix: undefined accessibility label
cd5593c
@OtavioStasiak
chore: updated translations
caae3af
@OtavioStasiak
chore: update validations
52d48d0
@OtavioStasiak
chore: updated E2EEnterYourPasswordView layout
cf8ca1c
@OtavioStasiak
fix: added label on show and hide password input
6a6b108
@OtavioStasiak
action: organized translations
6162fef
@OtavioStasiak
fix: label on closeButton
033a508
@OtavioStasiak
fix: lint
3ac3ff5
@OtavioStasiak
chore: pt-br translation
e78fc2a
@OtavioStasiak
action: organized translations
5569f9c
@OtavioStasiak
chore: improve code organization
45bb598
@OtavioStasiak
fix: updated e2e tests
5dcba04
@OtavioStasiak
fix: changeserver e2e test
ed5234b
@OtavioStasiak
fix: e2eencryption e2e test
2f0aa23
@OtavioStasiak
fix: e2e tests breaking
b1dafce
@OtavioStasiak
fix: flaky e2e android e2eencryption test
a67aa37
@OtavioStasiak
fix: e2e deeplinking test
e21fc4e
@OtavioStasiak
fix: dismiss keyboard on e2e register tests
9569d65
OtavioStasiak and others added 21 commits December 12, 2024 10:46
@OtavioStasiak
fix: changeserver e2e on android
01ce195
@OtavioStasiak
fix: changeuser e2e tests
5b95828
@OtavioStasiak
fix: added onSubmitEditing on registerView confirmPassword
b270716
@OtavioStasiak
fix: e2e tests
d604c2d
@OtavioStasiak
fix: update e2eencryption test
b270fc0
@OtavioStasiak
chore: updated a11y accessibility experience on password conditions
b513acb
@OtavioStasiak
fix: i18n labels
9c3cfad
@OtavioStasiak
action: organized translations
5d81282
@OtavioStasiak
fix: color and issues about a11y
8c14c32
@OtavioStasiak
fix: updated style and colors
e6bac6e
@OtavioStasiak
fix: lint
ff8ceca
@OtavioStasiak
fix: rollback merge
c1d7110
@OtavioStasiak
fix: updated translation
6ffe222
@OtavioStasiak
fix: formTextInput accessibilityLabel
31e717b
@OtavioStasiak
fix: removed comment
0d3fa19
@OtavioStasiak
chore: created CustomFields component, useVerifyPassword and useCusto…
4de5604 
…mFields
@OtavioStasiak
fix: new customFields rules and rename PasswordTips
907ad74
@OtavioStasiak
fix: lint
a958494
@OtavioStasiak
fix: buttonBackgroundSecondaryDefault color
447e715
@OtavioStasiak
fix: focus problem on iOS voiceOver
c863edc
@OtavioStasiak
fix: iOS experience and android title focus
fc4caf1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diegolmello diegolmello diegolmello requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@OtavioStasiak @diegolmello