-
Notifications
You must be signed in to change notification settings - Fork 261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Mention Rendering Issue in File Upload Descriptions #649
base: develop
Are you sure you want to change the base?
Conversation
Thank you so much for the contribution @SinghaAnirban005 Please run prettier formatter and ensure that your code follows the linting rules. |
@Spiral-Memory can you please approve the changes so that I can test it live |
Actually, I'm not sure whether we need this. I may need to have a discussion to understand it better. |
okay then when you are available we will disscuss |
Hey @SinghaAnirban005, can you share the video of this implementation so that I can check it visually? |
Case when user mentions himself in description of an attachmentEmbeddedChat._.Simple.-.Simple.Storybook.-.Brave.2024-11-05.12-00-19.mp4Case when user mentions other members in groupEmbeddedChat._.Simple.-.Simple.Storybook.-.Brave.2024-11-05.12-01-21.mp4 |
Hey @SinghaAnirban005, it looks good, but one thing to ask, does it displays the user profile when clicked on the mentioned user? This gets displayed in Rocketchat |
@devanshkansagra it does not !! |
Wait wait @SinghaAnirban005 |
No no, work in this only no need to create new issue |
@Spiral-Memory okay !! |
@SinghaAnirban005, |
@Spiral-Memory Thank you for your suggestions !! Will definitely refine my approach |
Brief Title
Fix Mention Rendering Issue in File Upload Descriptions
Acceptance Criteria fulfillment
Fixes #648
Closes #622
Video/Screenshots
After making necessary changes
PR Test Details
Implemented regex on the description's before they render and ensured that list of members appear on typing "@" in the description box
Note: The PR will be ready for live testing at https://rocketchat.github.io/EmbeddedChat/pulls/pr-<pr_number> after approval.