Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add the modal to confirm pinning message #451

Closed
wants to merge 6 commits into from

Conversation

Akshun-01
Copy link
Contributor

@Akshun-01 Akshun-01 commented Feb 7, 2024

Implement Confirmation before Pinning Message feature

Acceptance Criteria fulfillment

  • Check for the state to trigger the modal
  • Make the confirmation Modal
  • Handle confirmation or canceling of the modal

Fixes #450

Video/Screenshots

confirmPinMessage.mp4

@Akshun-01
Copy link
Contributor Author

Hey @abhinavkrin,
I wanted to add the current message instead of the quoted text.
Just like here to maintain consistency.
image

Do you know if there is any pre-existing component for it in the Modal?
Or should I make one myself?

Could you please review the changes and provide feedback.
Thanks! ^^

@Spiral-Memory
Copy link
Collaborator

You can use the code similar to this to achieve it with some tweaks:

 <MessageAvatarContainer
    message={message}
    sequential={false}
    isStarred={false}
/>
<MessageBodyContainer>
    {<MessageHeader message={message} isTimeStamped={false} />}
    <MessageBody>
        {message.attachments && message.attachments.length > 0 ? (
            message.file.name
        ) : (
            message.msg
        )}
    </MessageBody>
    <MessageMetrics
        message={message}
        isReplyButton={false}
    />
</MessageBodyContainer>

@Akshun-01
Copy link
Contributor Author

I made the changes!
This is the current status, and I would love to hear about any feedback or changes required.

pinMsgConfirm.mp4

@Akshun-01 Akshun-01 marked this pull request as ready for review February 20, 2024 18:07
@Akshun-01
Copy link
Contributor Author

These have conflicts in files, that I didn't change.
So I will open a new PR for this with the latest branch and these changes.

Closing this one!

@Akshun-01 Akshun-01 closed this Feb 22, 2024
@Akshun-01 Akshun-01 deleted the confirmPinMsg branch February 22, 2024 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Confirmation Before Pinning message
2 participants