Add QoS profile query parameters #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sea-bass
commented
Feb 22, 2023
sea-bass
commented
Feb 25, 2023
|
@sea-bass we've been using this in prod for a long time, if you want to finish this up we can merge it! |
It took me an eternity to tweak 2 lines, but it is ready. Fun fact: I tried building on my personal laptop that runs Ubuntu 24.04 / Rolling and this does not compile for 2 reasons. Filed an issue to track this: #143 |
EzraBrooks
approved these changes
Jun 28, 2024
bjsowa
pushed a commit
to fictionlab/web_video_server
that referenced
this pull request
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Public API Changes
N/A
Description
This PR add a
qos_profilequery parameter that allows specifying a non-default (QoS) profile for theImageTransportImageStreamerandROSCompressedStreamerclasses, which are the two that create ROS 2 subscribers with the default QoS profile.For example, to use the sensor data proflie, you could go to, e.g., the following URL:
This doesn't support all the profiles that exist in
rclcpp, but maybe some of the common ones? It's easy enough to add more as people need them. For our use case at PickNik, we needed thesensor_dataprofile to get things working, so that's our motivation.