Pass the subfolder of the service event location #957
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Per current implementation, when constructing the service event JavaScript file, we suppose the subfolder of the service event is "srv", but some package, e.g., slam_toolbox, the .srv files are put under srvs/ folder, so when requiring the service event, slam_toolbox__srvs__AddSubmap_Event.js, it will imports the requst file, which is slam_toolbox__srv__AddSubmap_Request.js, and lead to an error. This patch passes the subfolder to the spec when creating the service event JS file, so it can require the request/response files by a correct file name. Fix: RobotWebTools#955
minggangw
added a commit
that referenced
this pull request
Feb 8, 2024
Per current implementation, when constructing the service event JavaScript file, we suppose the subfolder of the service event is "srv", but some package, e.g., slam_toolbox, the .srv files are put under srvs/ folder, so when requiring the service event, slam_toolbox__srvs__AddSubmap_Event.js, it will imports the requst file, which is slam_toolbox__srv__AddSubmap_Request.js, and lead to an error. This patch passes the subfolder to the spec when creating the service event JS file, so it can require the request/response files by a correct file name. Fix: #955
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per current implementation, when constructing the service event JavaScript file, we suppose the subfolder of the service event is "srv", but some package, e.g., slam_toolbox, the .srv files are put under
srvs/folder, so when requiring the service event,slam_toolbox__srvs__AddSubmap_Event.js, it will imports the requst file, which is slam_toolbox__srv__AddSubmap_Request.js, and lead to an error.
This patch passes the subfolder to the spec when creating the service event JS file, so it can require the request/response files by a correct file name.
Fix: #955