Add willCheckConsistency option to enable/disable message consistency checking #947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
minggangw
changed the title
minggangw
added a commit
that referenced
this pull request
Feb 4, 2024
… checking (#947) Currently, when a publisher/client sends a topic/request, it will check the consistency of the message to be sent. For example, the following code will lead to an exception: ```js const pub_ = this.node.createPublisher('sensor_msgs/msg/JointState', 'topic_js'); const stringMsgObject = rclnodejs.createMessageObject('sensor_msgs/msg/JointState'); stringMsgObject.header.frame_id = '0'; ``` Because the `stamp` in `header` is not initialized. This patch adds an additional option for node when initializing, which is `willCheckConsistency` (default is `false`), so the code above can run as expected with the `stamp` initialized with default value. Meanwhile, user can set it to `true` to check the consistency intentionally. To achieve, this patch implements: 1. Add `willCheckConsistency` to the node option. 2. Update `message.dot` accordingly to check the consistency based on the node option above. 3. Update the unit tests: - test/test-security-related.js Fix: #937
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when a publisher/client sends a topic/request, it will check the consistency of the message to be sent. For example, the following code will lead to an exception:
Because the
stampinheaderis not initialized.This patch adds an additional option for node when initializing, which is
willCheckConsistency(default isfalse), so the code above can run as expected with thestampinitialized with default value. Meanwhile, user can set it totrueto check the consistency intentionally.To achieve, this patch implements:
willCheckConsistencyto the node option.message.dotaccordingly to check the consistency based on the node option above.Fix: #937